Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI translations #2

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

AleIlMagno
Copy link

@AleIlMagno AleIlMagno commented Jul 1, 2024

Currently there is a bug that makes translations for the remaing expiration time not showing.
The reason seems that the these strings are saved in a separate plurals.xml and should be integrated in the near strings.xml

Also, other translation issues are due to the messed up mail-notifications file structure.
The usual path to strings is /(mail-notifications)/presentation/src/main/res/ , here there should be both the original and the translated strings. But currently the UPDATED original strings are in /mail-notifications/src/main/res/values/strings.xml
and the UPDATED translated strings are in /mail-notifications/src/src/main/res/ .

There is also no way to translate "Days" and "Hours" in /mail-composer/presentation/src/main/kotlin/ch/protonmail/android/mailcomposer/presentation/ui/SetExpirationTimeBottomSheetContent.kt and "(No Subject)" somewhere in /mail-mailbox/presentation/src/main/kotlin/ch/protonmail/android/mailmailbox/presentation/ .

Currently there is a bug that makes translations for the remaing expiration time not showing.
The reason seems that the these strings are saved in a separate plurals.xml and should be integrated in the near strings.xml
Currently there is a bug that makes translations for the remaing expiration time not showing.
The reason seems that the these strings are saved in a separate plurals.xml and should be integrated in the near strings.xml
Currently there is a bug that makes translations for the remaing expiration time not showing.
The reason seems that the these strings are saved in a separate plurals.xml and should be integrated in the near strings.xml
@AleIlMagno
Copy link
Author

AleIlMagno commented Jul 1, 2024

I don't know if this is all it takes to fix these issues.

@AleIlMagno
Copy link
Author

@nick0602

@AleIlMagno
Copy link
Author

@StefanijaBoshkovska

@AleIlMagno
Copy link
Author

@serdar-ozturk

@AleIlMagno
Copy link
Author

@armatys

@Twig6943
Copy link

Twig6943 commented Sep 2, 2024

could somebody upload the app to fdroid? (idk where else to say this) (an external repo would also be appreciated)

@Gitchick57
Copy link

Gitchick57 commented Sep 2, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants