Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is a bug that makes translations for the remaing expiration time not showing.
The reason seems that the these strings are saved in a separate plurals.xml and should be integrated in the near strings.xml
Also, other translation issues are due to the messed up mail-notifications file structure.
The usual path to strings is /(mail-notifications)/presentation/src/main/res/ , here there should be both the original and the translated strings. But currently the UPDATED original strings are in /mail-notifications/src/main/res/values/strings.xml
and the UPDATED translated strings are in /mail-notifications/src/src/main/res/ .
There is also no way to translate "Days" and "Hours" in /mail-composer/presentation/src/main/kotlin/ch/protonmail/android/mailcomposer/presentation/ui/SetExpirationTimeBottomSheetContent.kt and "(No Subject)" somewhere in /mail-mailbox/presentation/src/main/kotlin/ch/protonmail/android/mailmailbox/presentation/ .